[PATCH] D51798: [Dwarf/AArch64] Return address signing B key dwarf support

[Oliver Stannard via Phabricator via llvm-commits]

olista01 added inline comments.


================
Comment at: lib/MC/MCAsmStreamer.cpp:1585
+
+  OS << "\t.cfi_b_key_frame \"" << "\"";
+  EmitEOL();
----------------
This emits a pair of double quotes, which that parser doesn't expect. Also, there is no test for this.


================
Comment at: lib/MC/MCDwarf.cpp:1729
   static const CIEKey getEmptyKey() {
-    return CIEKey(nullptr, 0, -1, false, false, static_cast<unsigned>(INT_MAX));
+    return CIEKey(nullptr, 0, -1, false, false, static_cast<unsigned>(INT_MAX), false);
   }
----------------
80 columns (I'd suggest using git-clang-format on the patch).


================
Comment at: lib/MC/MCParser/AsmParser.cpp:4185
+/// parseDirectiveCFIBKeyFrame
+/// ::= .append_augmentation
+bool AsmParser::parseDirectiveCFIBKeyFrame() {
----------------
Outdated comment.


================
Comment at: lib/MC/MCParser/AsmParser.cpp:4186
+/// ::= .append_augmentation
+bool AsmParser::parseDirectiveCFIBKeyFrame() {
+  if (parseToken(AsmToken::EndOfStatement,
----------------
This should probably be restricted to AArch64, ideally by putting it in the AArch64 asm parser.


https://reviews.llvm.org/D51798