[PATCH] D51751: Merge clang's isRepeatedBytePattern with LLVM's isBytewiseValue

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a comment.

This patch will conflict with my patch here: https://reviews.llvm.org/D52092

Background: In our out-of-tree target we have 16-bit-bytes (so memset/memcpy etc operate on 16-bit units). We need to patch isBytewiseValue to handle both 8-bit and 16-bit bytes (we store BitsPerByte in various places such as DataLayout, so it could be 8 or 16 depending on target). The idea with https://reviews.llvm.org/D52092 was to make it possible to check BitsPerByte in isBytewiseValue, and then convert the existing isBytewiseValue into a more general isSplatValue that should work for any given bit length (similar to isSplat in APInt.h).

Do you think it is possible to use such a design here? (I doubt that it costs too much to have a more general isSplatValue in LLVM trunk)


Repository:
  rL LLVM

https://reviews.llvm.org/D51751