[PATCH] D52288: [MCA] Remove dependency on CodeGen.

Owen Rodley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 19 23:35:19 PDT 2018


orodley created this revision.
Herald added subscribers: llvm-commits, gbedwell, mgorny.
Herald added a reviewer: andreadb.
orodley edited the summary of this revision.

There isn't any actual dependency - there's one #include from CodeGen
but nothing from the header is actually used.

With this change we can use the MCA library from CodeGen without
circular dependencies (e.g. for scheduling).


Repository:
  rL LLVM

https://reviews.llvm.org/D52288

Files:
  llvm/tools/llvm-mca/lib/CMakeLists.txt
  llvm/tools/llvm-mca/lib/LLVMBuild.txt
  llvm/tools/llvm-mca/lib/Pipeline.cpp


Index: llvm/tools/llvm-mca/lib/Pipeline.cpp
===================================================================
--- llvm/tools/llvm-mca/lib/Pipeline.cpp
+++ llvm/tools/llvm-mca/lib/Pipeline.cpp
@@ -15,7 +15,6 @@
 
 #include "Pipeline.h"
 #include "HWEventListener.h"
-#include "llvm/CodeGen/TargetSchedule.h"
 #include "llvm/Support/Debug.h"
 
 namespace mca {
Index: llvm/tools/llvm-mca/lib/LLVMBuild.txt
===================================================================
--- llvm/tools/llvm-mca/lib/LLVMBuild.txt
+++ llvm/tools/llvm-mca/lib/LLVMBuild.txt
@@ -19,4 +19,4 @@
 type = Library
 name = MCA
 parent = Libraries
-required_libraries = CodeGen MC Support
+required_libraries = MC Support
Index: llvm/tools/llvm-mca/lib/CMakeLists.txt
===================================================================
--- llvm/tools/llvm-mca/lib/CMakeLists.txt
+++ llvm/tools/llvm-mca/lib/CMakeLists.txt
@@ -24,7 +24,6 @@
 
 llvm_update_compile_flags(LLVMMCA)
 llvm_map_components_to_libnames(libs
-  CodeGen
   MC
   Support
   )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52288.166226.patch
Type: text/x-patch
Size: 1025 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180920/344fa25d/attachment.bin>


More information about the llvm-commits mailing list