[PATCH] D52287: [unittests] Do not use llvm::sort in googlemock

[Eric Christopher via llvm-commits]

LGTM.

On Wed, Sep 19, 2018, 7:34 PM Dean Michael Berris via Phabricator <
reviews at reviews.llvm.org> wrote:

> dberris created this revision.
> dberris added reviewers: echristo, mgrang.
>
> This reverts r329475 which applied to googlemock. This change makes the
> googlemock implementation in LLVM dependent on LLVM unnecessarily.
>
>
> https://reviews.llvm.org/D52287
>
> Files:
>   llvm/utils/unittest/googlemock/include/gmock/gmock-matchers.h
>
>
> Index: llvm/utils/unittest/googlemock/include/gmock/gmock-matchers.h
> ===================================================================
> --- llvm/utils/unittest/googlemock/include/gmock/gmock-matchers.h
> +++ llvm/utils/unittest/googlemock/include/gmock/gmock-matchers.h
> @@ -2654,7 +2654,7 @@
>        LhsStlContainerReference lhs_stl_container =
> LhsView::ConstReference(lhs);
>        ::std::vector<LhsValue> sorted_container(lhs_stl_container.begin(),
>                                                 lhs_stl_container.end());
> -      ::llvm::sort(
> +      ::std::sort(
>             sorted_container.begin(), sorted_container.end(), comparator_);
>
>        if (!listener->IsInterested()) {
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180919/25aad1cc/attachment.html>