[PATCH] D52279: [sanitizer] Make __sanitizer::CheckFailed not public

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 19 16:12:19 PDT 2018


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

I ran the tests with your patch and everything passes, but of course, Timur mentioned that nothing in our test suite finds this issue. He probably encountered it in Chrome and it was hard to reduce into something we could add to the test suite.

I'd say, commit it, and we'll see if the CrWinASan bots come back green after the fact. They probably will. The need for this may have gone away as we restructured the various static and dynamic asan libraries.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D52279





More information about the llvm-commits mailing list