[PATCH] D50494: [LLD] Reserve memory in implicitly set LMARegions

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/LinkerScript.cpp:722
 
+static bool areFlagsCompatible(MemoryRegion *M, OutputSection *Sec) {
+  if (M->Flags && !(M->Flags & Sec->Flags))
----------------
What is the meaning of the expressions in the function? I'd write a brief function comment.


================
Comment at: ELF/LinkerScript.cpp:774
+
+static bool isLMARegionCompatible(MemoryRegion *M, OutputSection *Sec) {
+  return (Sec->Type & SHT_NOBITS) || areFlagsCompatible(M, Sec);
----------------
Needs a brief function comment.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50494