[PATCH] D51606: [XRay] Remove the deprecated __xray_log_init API

[Volodymyr Sapsai via Phabricator via llvm-commits]

vsapsai added a comment.

I have published https://reviews.llvm.org/D52278 for disabling the test on Darwin. So far my investigation shows that `__xray_log_select_mode("xray-fdr")` returns 2 (aka `XRAY_MODE_NOT_FOUND`) and that's why we are calling `std::abort`.

  if (__xray_log_select_mode("xray-fdr") !=
      XRayLogRegisterStatus::XRAY_REGISTRATION_OK)
    std::abort();

Any advices on how to troubleshoot this situation? I tried `XRAY_OPTIONS="verbosity=1"` and `XRAY_FDR_OPTIONS="verbosity=1"` but there is no extra logging. I am using clang version 8.0.0 (trunk 342513) and it has libclang_rt.xray-basic_osx.a, libclang_rt.xray-fdr_osx.a, libclang_rt.xray-profiling_osx.a, libclang_rt.xray_osx.a.

I have a smallish repro but I need to clean it up. Writing this I realized that in that repro we are using pieces of host compiler, not compiler-under-test (`-isysroot`, `-B`). Depending on the time FDR mode was added, host compiler might not have support for it.


Repository:
  rL LLVM

https://reviews.llvm.org/D51606