[PATCH] D50560: [LLD] Enable Visual Studio compatible diagnostics.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 19 14:08:53 PDT 2018


ruiu added a comment.

I haven't read Diagnostics.cpp to focus on the ABI itself, but it looks like this approach is better than https://reviews.llvm.org/D47540, though this patch seems a bit too abstracted and too object-oriented to my taste. Can you add comment to the code? Also, please avoid operator overriding and eliminate Diag class (you can do that because all you need is a boolean flag indicating whether VS output is wanted or not.)


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50560





More information about the llvm-commits mailing list