[PATCH] D52213: [OCaml] Add OCaml API for __cxa_demangle

Josh Berdine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 19 14:02:04 PDT 2018


jberdine added a comment.

Thanks for the suggestion @erik.pilkington. I assume you mean to call the `itaniumDemangle` function declared in `include/llvm/Demangle/Demanagle.h`. Since that is in the `llvm` namespace, it would need a shim extern C function in C++ to call from the OCaml bindings. It's not clear to me that such a function would be welcome in e.g. `lib/IR/Core.cpp`. There could be other options I'm overlooking. My brief experiments adding some C++ code under `bindings/ocaml` all failed to compile, but maybe there is some build system magic that would make that work. But since it is possible for clients of the OCaml API to call `__cxa_demangle` without exposing it here, maybe @whitequark is right that it doesn't fit.


Repository:
  rL LLVM

https://reviews.llvm.org/D52213





More information about the llvm-commits mailing list