[PATCH] D52105: [WebAssembly] Add V128 value type to binary format

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: test/MC/WebAssembly/types.ll:1
+; RUN: llc -wasm-enable-unimplemented-simd -mattr=+sign-ext,+simd128 -filetype=obj %s -o - | obj2yaml | FileCheck %s
+
----------------
tlively wrote:
> aheejin wrote:
> > tlively wrote:
> > > aheejin wrote:
> > > > What's the purpose of this test?
> > > It checks that the ValTypes are emitted to an object file correctly, including the new V128 one.
> > Nit: Then probably it would make more sense to move this to D52254..?
> I think at least part of this test belongs in this CL since it's the only thing testing the ObjectYAML support for V128, but splitting up the test file into two commits is probably more trouble than it's worth, so I would prefer to just keep it here.
Yeah that makes sense.


Repository:
  rL LLVM

https://reviews.llvm.org/D52105