[PATCH] D52105: [WebAssembly] Add V128 value type to binary format

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 19 11:21:33 PDT 2018


aheejin added inline comments.


================
Comment at: test/MC/WebAssembly/types.ll:10
+declare <16 x i8> @v16i8(<16 x i8> %v)
+declare <8 x i16> @v8i16()
+declare <4 x i32> @v4i32()
----------------
aheejin wrote:
> No argument for rest of functions?
Oh, I wasn't suggesting deleting the argument... actually was suggesting adding it to other functions too (for symmetry), but if you don't think we need it, that's probably fine.


Repository:
  rL LLVM

https://reviews.llvm.org/D52105





More information about the llvm-commits mailing list