[compiler-rt] r342553 - [UBSan] Fix typo in CMake conditional that checked if the architecture
Dan Liew via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 19 08:27:00 PDT 2018
Author: delcypher
Date: Wed Sep 19 08:27:00 2018
New Revision: 342553
URL: http://llvm.org/viewvc/llvm-project?rev=342553&view=rev
Log:
[UBSan] Fix typo in CMake conditional that checked if the architecture
of a darwin platform was in the list of `UBSAN_SUPPORTED_ARCH`.
This is a follow up to r341306.
The typo meant that if an architecture was a prefix to another
architecture in the list (e.g. `armv7` is a prefix of `armv7k`) then
this would trigger a match which is not the intended behaviour.
rdar://problem/41126835
Modified:
compiler-rt/trunk/test/ubsan/CMakeLists.txt
Modified: compiler-rt/trunk/test/ubsan/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/CMakeLists.txt?rev=342553&r1=342552&r2=342553&view=diff
==============================================================================
--- compiler-rt/trunk/test/ubsan/CMakeLists.txt (original)
+++ compiler-rt/trunk/test/ubsan/CMakeLists.txt Wed Sep 19 08:27:00 2018
@@ -117,7 +117,7 @@ if(APPLE)
string(REPLACE ";" " " UBSAN_TEST_TARGET_ARCH_FLAGS "${UBSAN_TEST_TARGET_ARCH_FLAGS_AS_LIST}")
set(UBSAN_TEST_TARGET_CFLAGS
"${UBSAN_TEST_TARGET_ARCH_FLAGS} -isysroot ${DARWIN_${platform}_SYSROOT}")
- if (";${UBSAN_SUPPORTED_ARCH};" MATCHES ";${arch}")
+ if (";${UBSAN_SUPPORTED_ARCH};" MATCHES ";${arch};")
add_ubsan_device_testsuite("Standalone" ubsan ${platform} ${arch})
endif()
More information about the llvm-commits
mailing list