[PATCH] D51216: Fix IRBuilder.CreateFCmp(X, X) misfolding

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

What i think is missing here, is that

> The code incorrectly inferred that the relationship of a constant expression X to itself is FCMP_OEQ (ordered and equal), when it's actually FCMP_UEQ (unordered or equal).

simply states it as the matter of a fact.
Clearly, since this patch is here, the previous choice was wrong (i guess?).
So some more blurb with explanation as to //why// it is so would be good.
(i'm guessing `nan` / `inf` etc?)


Repository:
  rL LLVM

https://reviews.llvm.org/D51216