[PATCH] D52099: [PPC64] Add split-stack support.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Arch/PPC64.cpp:717
+// -) The allocate_more_stack block might be placed after the split-stack
+//    prologue  and the `blt-` replaced with a `bge+ .Lnormal_func_body`
+//    instead.
----------------
there's an extra space after "prologue"


================
Comment at: ELF/Arch/PPC64.cpp:761
+  if (getPrimaryOpCode(SecondInstr) == 14) {
+    assert(!LoImm);
+    LoImm = SecondInstr & 0xFFFF;
----------------
I think this can be triggered by feeding an object file that doesn't comply with the ABI standard, so this shouldn't be an assert. I'd just omit this check.


================
Comment at: ELF/Arch/PPC64.cpp:794
+  if (HiImm) {
+    write32(Loc + 4, 0x3D810000 | (uint16_t)HiImm);
+    // If the low immediate is zero the second instruction will be a nop.
----------------
Do you need a cast?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52099