[PATCH] D51632: [New PM][PassInstrumentation] enhancing PassInstrumentation with PassManager tracking

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

In https://reviews.llvm.org/D51632#1239228, @philip.pfaffe wrote:

> I don't fully understand the rationale behind this. How is this different compared to a before/after instrumentation matching the PassManagers?


To be honest, the rationale is nearly dead.
It was useful for -time-passes when we were passing instance pointers and were doing nontrivial things with PM timers.
Right now we just ignore pass managers there.
So the only reason for these interface existence is that I would like to be able to move DebugLogging functionality to PassInstrumentation
and start/finish points are the only places in code where we have DebugLogging that is not yet covered by PassInstrumentation.

That hints these points might be useful for nontrivial instrumentations in future.
I can defer this patch until I prepare DebugLogging replacement patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D51632