[PATCH] D52035: [MIPS][MicroMIPS] Fix the definition of MOVEP instruction

Milena Vujosevic Janicic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 19 02:49:24 PDT 2018


milena.vujosevic.janicic added a comment.

In https://reviews.llvm.org/D52035#1238387, @atanasyan wrote:

> Could that be tested somehow?


Definition of MOVEP is changed but all the previously written test cases pass, so this change is tested by these old tests.

Problems with the old definition cannot be seen without code in https://reviews.llvm.org/D52037. Generating MOVEP from MicroMipsSizeReduce pass would fail with machine verifier error if this definition is not fixed. 
(This is similar to the changes done for LWP/SWP instructions https://reviews.llvm.org/D47255 and https://reviews.llvm.org/D39115).


https://reviews.llvm.org/D52035





More information about the llvm-commits mailing list