[PATCH] D52223: [dwarfdump] Verify DW_AT_type.

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 19 01:10:50 PDT 2018


JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:195
+              << " is missing type attribute:\n";
+      Die.dump(OS, 0);
+      OS << '\n';
----------------
aprantl wrote:
> It might be nice to define an `operator<<(const Die&)` for this presumably(?) common case.
I've added a helper function in r342526. The operator isn't an option here because we have to pass the DIDumpOptions, something I apparently forgot here. Another benefit of the new helper :-) 


Repository:
  rL LLVM

https://reviews.llvm.org/D52223





More information about the llvm-commits mailing list