[PATCH] D52168: [DWARF] - Emit the correct value for DW_AT_addr_base.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.
Herald added a subscriber: jsji.


================
Comment at: test/DebugInfo/X86/debug_addr.ll:34
 ; DWARF5: DW_AT_GNU_dwo_name{{.*}}test.dwo
-; DWARF5: DW_AT_GNU_addr_base{{.*}}0x00000000
+; DWARF5: DW_AT_GNU_addr_base{{.*}}0x00000008
 ; DWARF5: .debug_addr contents:
----------------
dblaikie wrote:
> This looks suspicious, I think? This test is for DWARF4 so why does it have a non-zero addr_base?
No :) This test file is for both `DWARF4` and `DWARF5`. See the corresponding check tags. For DWARF4 it is zero (line 20).
This place is exactly what needed to be fixed to show that this patch does the right thing now.


https://reviews.llvm.org/D52168