[PATCH] D47858: [New PM] Introducing PassInstrumentation framework

Philip Pfaffe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 19 00:42:33 PDT 2018


philip.pfaffe accepted this revision.
philip.pfaffe added a comment.

So I'd still prefer a generic free getAnalysisResult, plus specializations for the non-simple cases, e.g. Loop and CGSCC. That way there's less surprises should there ever be a 'weird' AnalysisManager out there using a different argument mapping. Happy to do this in a followup though!

Thank you again for bearing through this lengthy review process!


Repository:
  rL LLVM

https://reviews.llvm.org/D47858





More information about the llvm-commits mailing list