[PATCH] D50297: Align AArch64 and i386 image base to superpage

[Mark Johnston via Phabricator via llvm-commits]

markj added a comment.

In https://reviews.llvm.org/D50297#1237404, @peter.smith wrote:

> Does FreeBsd use 4Kb granules for the page size or the LLD default of 64Kb. From what I can see from the MMU documentation when 64Kb pages are used the equivalent of the Super Page size is 512MiB and not 2 MiB? If I'm right then aligning to 2MiB is only going to be beneficial when 4Kb pages are used. On the assumption that it doesn't do much harm to people using 64Kb pages I don't have any objections in changing it though. Aligning to 512MiB for 64kb pages sounds a bit extreme though.


Currently we don't have any support for anything other than 4KB pages on aarch64. This change doesn't have any effect on 64KB alignment so I can't see why anyone using 64KB pages would be negatively affected.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50297