[PATCH] D52105: [WebAssembly] Add V128 value type to binary format

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: test/CodeGen/WebAssembly/call.ll:15
 declare double @double_nullary()
+declare <16 x i8> @simd_nullary()
 declare void @void_nullary()
----------------
Nit: `v128_nullary` or `v16i8_nullary` for symmetry?


================
Comment at: test/CodeGen/WebAssembly/call.ll:124
+  ret i64 %t
+}
+
----------------
Maybe we can make this call-related stuff another CL, which is not relevant to V128?


================
Comment at: test/MC/WebAssembly/types.ll:1
+; RUN: llc -wasm-enable-unimplemented-simd -mattr=+sign-ext,+simd128 -filetype=obj %s -o - | obj2yaml | FileCheck %s
+
----------------
What's the purpose of this test?


================
Comment at: test/MC/WebAssembly/types.ll:10
+declare <16 x i8> @v16i8(<16 x i8> %v)
+declare <8 x i16> @v8i16()
+declare <4 x i32> @v4i32()
----------------
No argument for rest of functions?


================
Comment at: test/MC/WebAssembly/types.ll:18
+entry:
+    %tmp1 = call i32 @i32()
+    %tmp2 = call i64 @i64()
----------------
Nit: indentation 2 spaces


Repository:
  rL LLVM

https://reviews.llvm.org/D52105