[PATCH] D52238: [CodeGen] Enable tail calls for functions with NonNull attributes.
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 18 14:50:58 PDT 2018
dmgreen added inline comments.
================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:1876
- .removeAttribute(Attribute::NoAlias))
- continue;
-
----------------
efriedma wrote:
> I don't follow why you're deleting this code.
Oh right, I meant to put a comment about that. From what I can tell it appears to be testing CalleeAttrs against itself, and this check should be handled by the calls to attributesPermitTailCall above. Unless I'm missing what this is testing?
https://reviews.llvm.org/D52238
More information about the llvm-commits
mailing list