[PATCH] D52231: [PPC64] Add helper for calculating the offset from a functions global entry to its local entry. [NFC]

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 18 13:40:20 PDT 2018


MaskRay added inline comments.
Herald added a subscriber: jsji.


================
Comment at: ELF/Arch/PPC64.cpp:89
+  llvm_unreachable(
+      "reserved value of 7 in the 3 most-significant-bits of st_other ");
+}
----------------
Remove the trailing space `st_other "`


================
Comment at: ELF/Target.h:178
+// point (LEP) which bypasses the TOC pointer initialization code. The
+// offset between GEP and LEP is encoded in a functions st_other flags.
+// This function will return the offset (in bytes) from the global entry-point
----------------
Typo. `function's`


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52231





More information about the llvm-commits mailing list