[PATCH] D49915: [IR] Add a boolean field in DILocation to know if a line must covered or not

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Thanks, I think this looks good with a minor tweak to the test.



================
Comment at: test/Bitcode/DILocation-implicit-code.ll:169-170
+!11 = !DILocation(line: 16, column: 9, scope: !7)
+; CHECK: !12 = !DILocation(line: 20, column: 1, scope: !7, isImplicitCode: true)
+; CHECK: !13 = !DILocation(line: 17, column: 5, scope: !7, isImplicitCode: true)
+!14 = !DILocation(line: 18, column: 22, scope: !7)
----------------
I think it's best if you don't comment out the original DILocation metadata so that someone can easily regenerate the .bc file. Add a separate, new CHECK line. You should also ignore irrelevant !N markers if you can. Something like this is best, since llvm-dis could add some auto-upgrading that disrupts the metadata numbering:
```
; CHECK: !DILocation(line: 20, column: 1, scope: !{{[0-9]+}}, isImplicitCode: true)
; CHECK: !DILocation(line: 17, column: 5, scope: !{{[0-9]+}}, isImplicitCode: true)
```


Repository:
  rL LLVM

https://reviews.llvm.org/D49915