[PATCH] D52057: Emit template type and value parameter DIEs for template variables.

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: test/DebugInfo/X86/template.ll:6-9
 ; template<int x, int*, template<typename> class y, decltype(nullptr) n, int ...z>  int func() { return 3; }
 ; template<typename> struct y_impl { struct nested { }; };
 ; int glbl = func<3, &glbl, y_impl, nullptr, 1, 2>();
 ; y_impl<int>::nested n;
----------------
I'm guessing this source code is out of date, since it doesn't appear to include a global variable template named 'var'?


================
Comment at: test/DebugInfo/X86/template.ll:20
+; CHECK: DW_TAG_variable
+; CHECK-NEXT: DW_AT_name{{.*}}"var"
 ; CHECK-NOT: NULL
----------------
Presumably this should actually be named 'var<int>'? Not a big deal, since this is just using whatever name is in the IR To begin with - but might make the test case less confusing.


Repository:
  rL LLVM

https://reviews.llvm.org/D52057