[PATCH] D52234: [docs][AtomicExpandPass] Document the alternate lowering strategy for part-word atomicrmw/cmpxchg

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 18 10:02:17 PDT 2018


jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.

I'd prefer it to more strongly indicate that the IR-level LL/SC lowering is broken and should not be used in the future, and hopefully will be removed once targets have migrated off of it.

But since there is not yet universal agreement for doing that, this is fine for the moment.



================
Comment at: docs/Atomics.rst:474
+in IR, calling target lowering hooks to emit intrinsics for the LL and SC
+operations. Many architectures have strict requirements for LL/SC loops to
+ensure forward progress, such as restrictions on the number and type of instructions
----------------
I'd insert a "However, " here.


https://reviews.llvm.org/D52234





More information about the llvm-commits mailing list