[PATCH] D52222: [clangd] Merge ClangdServer::DynamicIndex into FileIndex. NFC.

Sam McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 18 05:45:26 PDT 2018


sammccall added inline comments.


================
Comment at: clangd/index/FileIndex.h:77
+  /// Update symbols from main file \p Path with symbols in \p TopLevelDecls.
+  void updateMain(PathRef Path, ASTContext &AST,
+                  std::shared_ptr<Preprocessor> PP,
----------------
sammccall wrote:
> can't this just take PathRef + ParsedAST?
> (same data, but clearer semantics)
You're still taking the top-level decls, these can just come from the ParsedAST though?


Repository:
  rL LLVM

https://reviews.llvm.org/D52222





More information about the llvm-commits mailing list