[PATCH] D51841: [llvm-objcopy] Dwarf decompression support.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-objcopy/compress-debug-sections-zlib-gnu.test:10
 # RUN: llvm-readobj -relocations -s %t-compressed.o | FileCheck %s --check-prefix=CHECK-FLAGS
+# RUN: llvm-objdump -s %t-decompressed.o -section=.debug_foo | FileCheck %s
 
----------------
This still isn't a good enough test. All it does is show that we have a section named .debug_foo after decompression. It shows nothing about the properties of the section header or that the section has been decompressed. You need to check both (e.g. by comparing the contents of the section/section header before and after decompression). If you bring across the comparisons in compress-debug-sections.test, then that at least will cover the contents aspect.


================
Comment at: tools/llvm-objcopy/Object.h:369
   MAKE_SEC_WRITER_FRIEND
+  friend class DecompressedSection;
 
----------------
Why this? You should just provide getters. Don't use friend here.


Repository:
  rL LLVM

https://reviews.llvm.org/D51841