[PATCH] D52210: [LLVM-C][OCaml] Add C and OCaml APIs to access DebugLoc info

[whitequark via Phabricator via llvm-commits]

whitequark requested changes to this revision.
whitequark added a comment.
This revision now requires changes to proceed.

Why are there three sets of functions that all operate on `LLVMValueRef`? Can't we make it a single set of functions?

All new C API functions that return strings must accept an `unsigned *Length` parameter.

Since this is a rather nontrivial addition to the C API, I think you should split this into a C patch which I'd like to get a second opinion on, and then a separate OCaml patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D52210