[PATCH] D52126: Discard uncompressed buffer after creating .gdb_index contents.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 17 16:39:56 PDT 2018


dblaikie added a comment.

Fair question - for Google, stream uncompressing to disk wouldn't help
matters - disk is a ramfs, so it's the same as uncompressing the whole
thing to a buffer in memory, which hurts a bit (due to memory limits).

For somewhat more "normal" users (I assume compressed debug info was
probably implemented before google's needs - but I could be wrong there,
maybe Google folks implemented it in gold/gcc before the LLVM switch) -
especially pre-Fission, debug info was the big culprit. Though that doesn't
mean it was better to just compress it rather than compressing everything.
Perhaps because keeping the object file as the outer container meant more
things continued to "just work" - objdump, etc, things that relied only on
the object file headers and not the section contents.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52126





More information about the llvm-commits mailing list