[PATCH] D52161: [XRay] Encapsulate all FD log related logic into a class

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: compiler-rt/lib/xray/xray_utils.cc:89-90
 
-  return Fd;
+  LogWriter *LW = reinterpret_cast<LogWriter *>(InternalAlloc(sizeof(LogWriter)));
+  new (LW) LogWriter(Fd);
+  return LW;
----------------
dberris wrote:
> dberris wrote:
> > Is it possible to avoid using `InternalAlloc` and `InternalFree` here, and instead use the XRay-specific allocators in xray_allocator.h (`allocate<T>(...)` and `deallocate(...)`)?
> Marked done but I don't see the changes -- I still see InternalAlloc and InternalFree?
I accidentally reuploaded the old patch, sorry about that.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D52161