[PATCH] D35035: [InstCombine] Prevent memcpy generation for small data size

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 17 15:40:59 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D35035#1237401, @hiraditya wrote:

> I think this patch is good to go, I can push this if someone accepts. I'll fix the comments.


I still don't understand the (LargestInt == 0) hack. I think everyone agrees that the existing code is wrong, so why preserve the existing behavior if we don't have a valid datalayout? Ie, there's no risk for real targets because they always have a non-zero getLargestLegalIntTypeSizeInBits()?


https://reviews.llvm.org/D35035





More information about the llvm-commits mailing list