[PATCH] D52192: Add !thread.private metadata

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 17 14:37:08 PDT 2018


reames added a comment.

Just noting a couple of known gaps (to save reviewers time):

- No verifier support (will add before submission)
- Need to add references from each support instruction type in the docs (done to avoid rebase headache)

Follow on things which need to happen later:

- Once we settle on naming, extra and rename existing logic in LICM and DSE into a utility file in Analysis.
- Add a way to test that analysis in isolation.  (print-thread-private or something)



================
Comment at: docs/LangRef.rst:5430
 
 '``invariant.group``' Metadata
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
----------------
FIXME: Change to thread.private.


Repository:
  rL LLVM

https://reviews.llvm.org/D52192





More information about the llvm-commits mailing list