[PATCH] D49237: [PPC64] Optimize redundant instructions using R_PPC64_TOC16_HA in nop

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 17 14:27:14 PDT 2018


sfertile marked 4 inline comments as done.
sfertile added inline comments.


================
Comment at: ELF/Driver.cpp:287-288
+
+    if (Args.hasArg(OPT_no_toc_optimize))
+      error("--no-toc-optimize is only supported on the PowerPC64 target.");
+  }
----------------
ruiu wrote:
> ruiu wrote:
> > It is indeed true that --no-toc-optimize is PPC64 only, but in other test patterns we don't care about that kind of negative flags. I'd check if `Config->TocOptimize` is true.
> What about this?
Forgot to update that in the diff, its fixed now.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D49237





More information about the llvm-commits mailing list