[PATCH] D52188: [MC] Avoid inlining constant symbols with variants.

[Nirav Dave via Phabricator via llvm-commits]

niravd created this revision.
niravd added reviewers: nickdesaulniers, rnk.
Herald added subscribers: hiraditya, nemanjai.

Defer unnecessary early inlining of constants to symbol
variants. Fixes PR38945.


Repository:
  rL LLVM

https://reviews.llvm.org/D52188

Files:
  llvm/lib/MC/MCParser/AsmParser.cpp
  llvm/test/MC/PowerPC/pr38945.s


Index: llvm/test/MC/PowerPC/pr38945.s
===================================================================
--- /dev/null
+++ llvm/test/MC/PowerPC/pr38945.s
@@ -0,0 +1,13 @@
+// RUN: llvm-mc -triple=powerpc64-pc-linux %s -o - | FileCheck %s
+
+NUMBER = 0x6ffffff9
+
+        .text
+.globl  main
+main:
+	cmpwi   8,(NUMBER)@l
+	cmpwi   8,NUMBER at l
+
+// CHECK: main:
+// CHECK: cmpwi 8, -7
+// CHECK: cmpwi 8, -7	
Index: llvm/lib/MC/MCParser/AsmParser.cpp
===================================================================
--- llvm/lib/MC/MCParser/AsmParser.cpp
+++ llvm/lib/MC/MCParser/AsmParser.cpp
@@ -1125,7 +1125,7 @@
     // semantics in the face of reassignment.
     if (Sym->isVariable()) {
       auto V = Sym->getVariableValue(/*SetUsed*/ false);
-      bool DoInline = isa<MCConstantExpr>(V);
+      bool DoInline = isa<MCConstantExpr>(V) && !Variant;
       if (auto TV = dyn_cast<MCTargetExpr>(V))
         DoInline = TV->inlineAssignedExpr();
       if (DoInline) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52188.165812.patch
Type: text/x-patch
Size: 978 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180917/57cda44d/attachment.bin>