[PATCH] D52181: [benchmark] Lowercase windows specific includes

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 17 11:37:46 PDT 2018


mstorsjo created this revision.
mstorsjo added reviewers: smeenai, rnk, kbobyrev.

The windows SDK headers don't have self-consistent casing anyway, so we consistently use lowercase for these in other places, in order to fix crosscompilation with mingw headers.


Repository:
  rL LLVM

https://reviews.llvm.org/D52181

Files:
  utils/benchmark/src/colorprint.cc
  utils/benchmark/src/sleep.cc
  utils/benchmark/src/sysinfo.cc
  utils/benchmark/src/timers.cc


Index: utils/benchmark/src/timers.cc
===================================================================
--- utils/benchmark/src/timers.cc
+++ utils/benchmark/src/timers.cc
@@ -16,10 +16,10 @@
 #include "internal_macros.h"
 
 #ifdef BENCHMARK_OS_WINDOWS
-#include <Shlwapi.h>
+#include <shlwapi.h>
 #undef StrCat  // Don't let StrCat in string_util.h be renamed to lstrcatA
-#include <VersionHelpers.h>
-#include <Windows.h>
+#include <versionhelpers.h>
+#include <windows.h>
 #else
 #include <fcntl.h>
 #ifndef BENCHMARK_OS_FUCHSIA
Index: utils/benchmark/src/sysinfo.cc
===================================================================
--- utils/benchmark/src/sysinfo.cc
+++ utils/benchmark/src/sysinfo.cc
@@ -15,10 +15,10 @@
 #include "internal_macros.h"
 
 #ifdef BENCHMARK_OS_WINDOWS
-#include <Shlwapi.h>
+#include <shlwapi.h>
 #undef StrCat  // Don't let StrCat in string_util.h be renamed to lstrcatA
-#include <VersionHelpers.h>
-#include <Windows.h>
+#include <versionhelpers.h>
+#include <windows.h>
 #else
 #include <fcntl.h>
 #ifndef BENCHMARK_OS_FUCHSIA
Index: utils/benchmark/src/sleep.cc
===================================================================
--- utils/benchmark/src/sleep.cc
+++ utils/benchmark/src/sleep.cc
@@ -21,7 +21,7 @@
 #include "internal_macros.h"
 
 #ifdef BENCHMARK_OS_WINDOWS
-#include <Windows.h>
+#include <windows.h>
 #endif
 
 namespace benchmark {
Index: utils/benchmark/src/colorprint.cc
===================================================================
--- utils/benchmark/src/colorprint.cc
+++ utils/benchmark/src/colorprint.cc
@@ -25,7 +25,7 @@
 #include "internal_macros.h"
 
 #ifdef BENCHMARK_OS_WINDOWS
-#include <Windows.h>
+#include <windows.h>
 #include <io.h>
 #else
 #include <unistd.h>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52181.165795.patch
Type: text/x-patch
Size: 1748 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180917/920f81e0/attachment.bin>


More information about the llvm-commits mailing list