[PATCH] D52002: Switch optimization for known maximum switch values
Ayonam Ray via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 17 04:06:19 PDT 2018
ayonam added a comment.
In https://reviews.llvm.org/D52002#1232509, @spatel wrote:
> I don't know enough about switch lowering to review this, so adding some more potential reviewers.
> But there are at least a couple of obvious changes needed before this can proceed:
>
> 1. The patch must include tests that show the difference with this patch.
> 2. The indentation and spacing are clearly off (use clang-format?), and variable naming doesn't conform with: http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
Thanks for the comments. I will take care of these issues when I resubmit the patch after the changes suggested by Hans.
Repository:
rL LLVM
https://reviews.llvm.org/D52002
More information about the llvm-commits
mailing list