[PATCH] D52142: [DebugInfo] Fix build when std::vector::iterator is a pointer

[Orivej Desh via Phabricator via llvm-commits]

orivej added a comment.

> Do you have an example of a c++ std library where this happens?

I'm using `libc++` with the patch given above. I don't know about other libraries where iterators are pointers, only that this is allowed by the C++ standard.

> we're currently not planning another release candidate before final, so it may have to wait for 7.0.1.

That's probably OK if all popular C++ libraries have iterator::value_type, although I'd be surprised if that's the case because its existence seems to be a non standardized convention.


Repository:
  rL LLVM

https://reviews.llvm.org/D52142