[PATCH] D52087: [IRBuilder] Fixup CreateIntrinsic to allow specifying Types to Mangle.

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 17 02:59:12 PDT 2018


nhaehnle added inline comments.


================
Comment at: include/llvm/IR/IRBuilder.h:690-693
+  /// Create a call to intrinsic \p ID with no operands, mangled using \p Types.
+  CallInst *CreateIntrinsic(Intrinsic::ID ID, ArrayRef<Type *> Types,
                             Instruction *FMFSource = nullptr,
                             const Twine &Name = "");
----------------
I think it'd be best to remove this overload. It made sense with the "magic but broken" type deduction that was there before, but now anybody wishing to create a no-argument intrinsic can just pass `{}` to the overload below.


Repository:
  rL LLVM

https://reviews.llvm.org/D52087





More information about the llvm-commits mailing list