[PATCH] D52163: -S as an alias for --strip-all-gnu

[Dmitry Golovin via Phabricator via llvm-commits]

tpimh updated this revision to Diff 165726.
tpimh added a comment.

Changed the test to a version suggested by @srhines, changed option type to Flag as it doesn't take an argument.


Repository:
  rL LLVM

https://reviews.llvm.org/D52163

Files:
  test/tools/llvm-objcopy/strip-all-gnu.test
  tools/llvm-objcopy/ObjcopyOpts.td


Index: tools/llvm-objcopy/ObjcopyOpts.td
===================================================================
--- tools/llvm-objcopy/ObjcopyOpts.td
+++ tools/llvm-objcopy/ObjcopyOpts.td
@@ -67,6 +67,8 @@
                 HelpText<"Remove non-allocated sections other than .gnu.warning* sections">;
 def strip_all_gnu : Flag<["-", "--"], "strip-all-gnu">,
                     HelpText<"Compaitable with GNU objcopy's --strip-all">;
+def S : Flag<["-"], "S">,
+        Alias<strip_all_gnu>;
 def strip_debug : Flag<["-", "--"], "strip-debug">,
                   HelpText<"Remove all debug information">;
 def strip_dwo : Flag<["-", "--"], "strip-dwo">,
Index: test/tools/llvm-objcopy/strip-all-gnu.test
===================================================================
--- test/tools/llvm-objcopy/strip-all-gnu.test
+++ test/tools/llvm-objcopy/strip-all-gnu.test
@@ -1,6 +1,9 @@
 # RUN: yaml2obj %s > %t
+# RUN: cp %t %t1
 # RUN: llvm-objcopy --strip-all-gnu %t %t2
 # RUN: llvm-readobj -file-headers -sections %t2 | FileCheck %s
+# RUN: llvm-objcopy -S %t1 %t3
+# RUN: cmp %t2 %t3
 
 !ELF
 FileHeader:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52163.165726.patch
Type: text/x-patch
Size: 1104 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180917/d0185e69/attachment.bin>