[PATCH] D52163: -S as an alias for --strip-all-gnu

[Stephen Hines via Phabricator via llvm-commits]

srhines added a comment.

Thanks for noticing this missing feature, as well as for the patch! You really should add a simple test to test/tools/llvm-objcopy/strip-all-gnu.test so that this doesn't ever regress. The test strip-all-and-keep-symbol.test is an example that has multiple RUN lines. Here is what you need to change the strip-all-gnu.test to (I believe) in order to get this working:

...

1. RUN: yaml2obj %s > %t
2. RUN: cp %t %t1
3. RUN: llvm-objcopy --strip-all-gnu %t %t2
4. RUN: llvm-readobj -file-headers -sections %t2 | FileCheck %s

1. RUN: llvm-objcopy -S %t1 %t3
2. RUN: cmp %t2 %t3

...

To check that everything works, you can run ninja check-all from your LLVM build directory (substitute whatever build system you used for ninja if you need to).


Repository:
  rL LLVM

https://reviews.llvm.org/D52163