[PATCH] D52161: [XRay] Encapsulate all FD log related logic into a class

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added inline comments.


================
Comment at: compiler-rt/lib/xray/xray_utils.cc:89-90
 
-  return Fd;
+  LogWriter *LW = reinterpret_cast<LogWriter *>(InternalAlloc(sizeof(LogWriter)));
+  new (LW) LogWriter(Fd);
+  return LW;
----------------
Is it possible to avoid using `InternalAlloc` and `InternalFree` here, and instead use the XRay-specific allocators in xray_allocator.h (`allocate<T>(...)` and `deallocate(...)`)?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D52161