[PATCH] D52142: [DebugInfo] Fix build when std::vector::iterator is a pointer

[Orivej Desh via Phabricator via llvm-commits]

orivej added a comment.

I have slightly extended the description.

I don't think this is possible to test with a unit test, as this requires an integration test with a c++ library those std::vector::iterator is a pointer. `libc++` becomes such a library with this diff applied to `include/vector`:

       typedef typename __base::pointer                 pointer;
       typedef typename __base::const_pointer           const_pointer;
  +    typedef typename __base::pointer                 iterator;
  +    typedef typename __base::const_pointer           const_iterator;
  -    typedef __wrap_iter<pointer>                     iterator;
  -    typedef __wrap_iter<const_pointer>               const_iterator;


Repository:
  rL LLVM

https://reviews.llvm.org/D52142