[PATCH] D52062: [InstCombine] Inefficient pattern for high-bits checking 3 (PR38708)
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Sep 15 05:04:48 PDT 2018
lebedev.ri added a comment.
In https://reviews.llvm.org/D52062#1235062, @spatel wrote:
> LGTM
Thank you for the review!
In https://reviews.llvm.org/D52062#1235062, @spatel wrote:
> might want to add a code comment that we're only expecting this pattern in the multi-use case otherwise, it would have been canonicalized to the 'not' form.
Yeah, good idea.
Repository:
rL LLVM
https://reviews.llvm.org/D52062
More information about the llvm-commits
mailing list