[PATCH] D52125: X86, AArch64, ARM: Do not attach debug location to spill/reload instructions

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

As Matthias points out, a spill/reload can't unambiguously be associated with a specific instruction.

Note that passing an empty location means that the instruction is described by the previous .loc directive in the stream (if one is present). I think the pedantic thing to do would be to use the special "line 0" location. However, that might bloat the line table and possibly interfere with the way llvm currently identifies prologues.

I think this is the right approach. LGTM, although a regression test on the ARM side wouldn't hurt :).


Repository:
  rL LLVM

https://reviews.llvm.org/D52125