[PATCH] D50923: [New PM][PassInstrumentation] IR printing support for New Pass Manager

[Philip Pfaffe via Phabricator via llvm-commits]

philip.pfaffe added a comment.

In https://reviews.llvm.org/D50923#1235572, @fedor.sergeev wrote:

> I want all the debugging options to work the same manner whether it is opt or any other tool/way to run the pipeline
>  (say, in our JIT compiler we do sometimes use -print options). And I want them to work the same way both in legacy and new pass manager.
>  That means the main controlling interface should better be joined (and thats where ShouldPrint come into play).


Note that I'm not saying we should abandon the -print command line options, just that the ShouldPrint functions are the entirely wrong place to access them. This indirection is simply not necessary anymore.

>> This way there's no need to involve the PassBuilder API,
> 
> PassBuilder API is there again for an easy setup in tools *like* opt.
>  Somehow I thought providing a central way to install all the "blessed" callbacks would be adequate, even if right now there is only a single tool that calls it.

I understand the motivation. Given my oversight below I don't have very strong feelings about this anymore. Since I suspect this will also house the timing instrumentation registration, that's a stronger argument for this API then.

> Callbacks are not installed if printing is not enabled.

You're right, I overlooked that bit.


Repository:
  rL LLVM

https://reviews.llvm.org/D50923