[PATCH] D51275: [New PM][PassInstrumentation] Adding PassInstrumentation to the AnalysisManager runs

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added inline comments.


================
Comment at: test/Other/new-pm-thinlto-defaults.ll:69
 ; CHECK-PRELINK-O-NODIS-NEXT: Running analysis: InnerAnalysisManagerProxy
-; CHECK-O-NEXT: Running analysis: PassInstrumentationAnalysis
+; CHECK-PRELINK-O-NEXT: Running analysis: PassInstrumentationAnalysis
 ; CHECK-O-NEXT: Starting llvm::Function pass manager run.
----------------
philip.pfaffe wrote:
> Why does this change?
Since this analysis is now run for analyses as well, order of executions somewhat changes (naturally, those analyses that hit cache are not run, including passinstrumenation one). Full debugging output made perfect sense to me, though it really took some time to figure out a proper set of checks that works for all RUNs, and now I honestly do not remember exact sequence.


Repository:
  rL LLVM

https://reviews.llvm.org/D51275