[PATCH] D52104: lld-link: print demangled symbol names for "undefined symbol" diagnostics

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:1020-1022
+  if (initializeOutputStream(nullptr, nullptr, OS, 1024))
+    // FIXME: Propagate out-of-memory as an error?
+    std::terminate();
----------------
Is this returning `true` if it fails?  Gross.  Can we make it return `false` if it fails?


https://reviews.llvm.org/D52104