[PATCH] D52115: [PPC64] Add helpers for read/writing an instruction while relocating a half16 type. [NFC]
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 14 12:15:18 PDT 2018
MaskRay added inline comments.
================
Comment at: ELF/Arch/PPC64.cpp:124
+// simplify reading and writing in that context.
+static void writeInstrFromHalf16(uint8_t* Loc, uint32_t Instr) {
+ uint8_t *InstrStart = Loc - (Config->EKind == ELF64BEKind ? 2U : 0U);
----------------
`uint8_t* Loc` -> `uint8_t *Loc`
================
Comment at: ELF/Arch/PPC64.cpp:129
+
+static uint32_t readInstrFromHalf16(const uint8_t* Loc) {
+ const uint8_t *InstrStart = Loc - (Config->EKind == ELF64BEKind ? 2U : 0U);
----------------
`uint8_t* Loc` -> `uint8_t *Loc`
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D52115
More information about the llvm-commits
mailing list