[PATCH] D51742: [AMDGPU] Fix regression with not maintaining MachineDominatorTree

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 14 11:50:51 PDT 2018


scott.linder updated this revision to Diff 165560.
scott.linder added a comment.

Address feedback: make MDT optional, add braces, run clang-format.

I was not aware of the new DT update API, but as far as I can tell it doesn't support MDT yet. MDT contains a DT, but it is not a subclass. It maintains some state on top of the DT which is resolved in batches, so directly updating the contained DT underneath it doesn't seem correct.


https://reviews.llvm.org/D51742

Files:
  lib/Target/AMDGPU/SIFixSGPRCopies.cpp
  lib/Target/AMDGPU/SIInstrInfo.cpp
  lib/Target/AMDGPU/SIInstrInfo.h
  lib/Target/AMDGPU/SIInstrInfo.td
  test/CodeGen/AMDGPU/mubuf-legalize-operands.ll
  test/CodeGen/AMDGPU/mubuf-legalize-operands.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51742.165560.patch
Type: text/x-patch
Size: 52435 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180914/65b37cdb/attachment.bin>


More information about the llvm-commits mailing list